On 4/12/07, David James <james@cs.toronto.edu> wrote:
> Hi Josh,
>
> With your patch, a request for a log message would still generate 1
> lookup per file affected in the revision. If a revision affects, say,
> a hundred thousand files, your patch would still trigger a hundred
> thousand provider lookups and a hundred thousand calls to said
> provider when a user requests to look at the log message.
>
> What is the overhead of a provider lookup and call as compared to a
> regular function call? If it's not a lot more expensive then maybe
> this is not an issue.
Without looking at Josh's patch, you should be able to do the provider
lookup at config time (2 hash tables lookups) and then you'd invoke
the function pointer each time. So, it should be the same as a
regular function call. The point is that you are bypassing Apache's
sub-req creation overhead which is why the performance can suck. It
should reduce to an identical call profile as artem's approach, but
keeping the modules distinct. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 12 21:10:21 2007