[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "SVNAuthorizationShortCircuit or something similar"

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2007-04-12 21:26:32 CEST

On 4/12/07, Josh Gilkerson <jwg@google.com> wrote:
> When we can do the lookup was one question that I had. Is it
> guaranteed that the authz register_hooks(where the provider is
> registered) is called before the dav configuration? Or should I be
> registering the provider somewhere else?

register_hooks is called when the modules are loaded into memory - it
is indeed the right place to register hooks.

So, by the time the configuration is processed, the providers should
already be registered - so you should be able to do a lookup and get
the associated vtable back and store that in mod_dav_svn's config
structure. So when mod_dav_svn needs to do authz, the config
structure should have the vtable available for invocation.

> In the patch, I do the lookup each time because it seemed the safest
> thing to do without knowing the order of these calls and it should be
> fast.

Safe, but not optimal. =) -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 12 21:26:43 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.