[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Question on extern "C" logic

From: Paul Burba <pburba_at_collab.net>
Date: 2007-03-23 15:18:50 CET

> -----Original Message-----
> From: C. Michael Pilato [mailto:cmpilato@collab.net]
> Sent: Friday, March 23, 2007 1:19 AM
> To: Daniel Rall
> Cc: Justin Erenkrantz; Garrett Rooney; Paul Burba;
> dev@subversion.tigris.org; dionisos@tigris.org
> Subject: Re: Question on extern "C" logic
>
> Daniel Rall wrote:
> > On Thu, 22 Mar 2007, Justin Erenkrantz wrote:
> >
> >> On 3/22/07, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> >>> The only case I can think of is if we expect this private
> header to
> >>> be included by C++ code in our tree, like JavaHL. Other
> than that
> >>> it's not necessary, but then again it's not like it really hurts
> >>> anything to put it there.
> >> And, there are also people who compile Subversion under
> C++ - not C.
> >> (Don't ask.) -- justin
> >
> > Yup, I was thinking of both these cases.
>
> Okay. Thanks, guys, for filling in the blanks, there.
>
> --
> C. Michael Pilato <cmpilato@collab.net>
> CollabNet <> www.collab.net <> Distributed
> Development On Demand

Thanks all for the info, svn_wc_private.h now has the extern "C" block.

Mike was right that my question was more about the need for extern "C"
around non-public APIs.

Anyway, not to beat a dead horse, but I noticed several other header
files outside of /include that don't have extern "C" either:

  subversion/libsvn_diff/diff.h
  subversion/libsvn_fs_fs/fs_fs.h
  subversion/libsvn_ra/wrapper_template.h
  subversion/libsvn_ra_serf/ra_serf.h
  subversion/tests/libsvn_delta/delta-window-test.h
  subversion/tests/libsvn_delta/range-index-test.h
  subversion/libsvn_subr/win32_crashrpt.h
  subversion/libsvn_subr/win32_crashrpt_dll.h

Per Justin's "don't ask" comment these should have it...OTOH, most of
these headers have been around a long time and nobody's complained that
I know of.

Paul B.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 23 15:19:24 2007

This is an archived mail posted to the Subversion Dev mailing list.