[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Question on extern "C" logic

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-23 18:28:53 CET

On Fri, 23 Mar 2007, Paul Burba wrote:
> Anyway, not to beat a dead horse, but I noticed several other header
> files outside of /include that don't have extern "C" either:
> subversion/libsvn_diff/diff.h
> subversion/libsvn_fs_fs/fs_fs.h
> subversion/libsvn_ra/wrapper_template.h
> subversion/libsvn_ra_serf/ra_serf.h
> subversion/tests/libsvn_delta/delta-window-test.h
> subversion/tests/libsvn_delta/range-index-test.h
> subversion/libsvn_subr/win32_crashrpt.h
> subversion/libsvn_subr/win32_crashrpt_dll.h
> Per Justin's "don't ask" comment these should have it...OTOH, most of
> these headers have been around a long time and nobody's complained that
> I know of.

Most (all?) of these headers are a little different -- because they're
module-private (instead of Subversion-private), they're unlikely to be
included by code like JavaHL.

OTOH, if you're compiling Subversion with a C++ compiler, they could
be annoying. We might as well add the extern "C" bit -- it certainly
doesn't cost us much in terms of complexity.

  • application/pgp-signature attachment: stored
Received on Fri Mar 23 18:34:02 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.