[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Sparse directories - mini-review

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-03-22 21:46:27 CET

Karl Fogel writes:
> You mean, the way I upgraded all the old wrappers in a chronological
> chain of API upgrades? For some reason I thought that was desirable,
> but then I realized it's pretty pointless (function-call overhead is
> not that high), and stopped doing it.
>

Yeah, including the docstrings in the public
headers if I recall correctly.

> But how does it introduce code duplication? I agree the work wasn't
> needed, but I think it was harmless...

In the trivial case the code duplication is obviously also trivial, but
sometimes compat wrappers aren't that trivial. Compat wrappers are one of the
areas we really undertest, so a cut-and-paste error here may well go into
a release undetected.

The problem is that you set precedence by doing this in some
places. People who look on existing code will
continue this code churny activity and that's bad for
maintainability.

That's why I'd rather like to see the changes
to preexisting compat wrappers that were introduced on
the sparse-directories branch to go away again.

thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 22 21:46:55 2007

This is an archived mail posted to the Subversion Dev mailing list.