[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Sparse directories - mini-review

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-03-23 04:48:46 CET

plundblad@google.com (Peter Lundblad) writes:
> Another thing I noted when I reviewed, but didn't bring up yet:
> When functions are revised on this branch, *all* compatibility
> wrappers are updated. That's not what we've been doing before. Is
> there a specific reason for that? If not, I think that's bad idea
> because it introduces code duplication in code that we test very
> seldom. that's not a big deal when the wrappers are trivial, but
> sometimes they aren't. This might be easier to get fixed befre the
> branch is merged.

You mean, the way I upgraded all the old wrappers in a chronological
chain of API upgrades? For some reason I thought that was desirable,
but then I realized it's pretty pointless (function-call overhead is
not that high), and stopped doing it.

But how does it introduce code duplication? I agree the work wasn't
needed, but I think it was harmless...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 22 19:49:06 2007

This is an archived mail posted to the Subversion Dev mailing list.