[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 2663 : Add --non-recursive to svnlook tree command

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-02-28 16:54:42 CET

Ping...

Has anybody had a chance to review Bill's patch? If nothing happens
with it, I'll attach it to issue 2663.

Thanks,
-Hyrum

William Nagel wrote:
> On Feb 4, 2007, at 2:16 AM, Karl Fogel wrote:
>
>> A comment on the code: you've made the 'indentation' parameter
>> to print_tree() have a new meaning. The doc string for that function
>> should change to reflect this.
>
> ...
>
>> Also, please provide a log message with your patch :-).
>
> I fixed the doc string for print_tree, as per your suggestion, and
> created a log message.
>
> A new patch for issue 2663, as well as the log message are attached.
>
> -Bill
>
>
> ------------------------------------------------------------------------
>
> Fix issue #2663: Added a --non-recursive (-N) option to svnlook.
>
> * subversion/svnlook/main.c
> (options_table): Add an element for the non-recursive option.
>
> (cmd_table): Add -N as a valid option for the tree command.
>
> (svnlook_opt_state): Add a boolean for storing the non-recursive state.
>
> (print_tree): Add a non_recursive parameter. Add a check against the
> non_recursive and indentation parameters to short-circuit recursion into the
> tree when non_recursive is true.
>
> (do_tree): Add a non_recursive parameter, and passed it through to the
> print_tree call.
>
> (subcommand_tree): Pass non_recursive state to do_tree.
>
> (main): Handle -N option.
>
> * subversion/tests/cmdline/svnlook_tests.py
> (test_non_recursive): New test case to exercise -N option.

Received on Wed Feb 28 16:54:59 2007

This is an archived mail posted to the Subversion Dev mailing list.