Did this every get committed?
-Hyrum
Erik Huelsmann wrote:
> I can. I'll do that later today.
>
> On 1/18/07, Daniel Rall <dlr@collab.net> wrote:
>> Hopeully Erik can just commit this patch, saving us the overhead of an
>> issue.
>>
>> On Tue, 16 Jan 2007, Hyrum K. Wright wrote:
>>
>> > Erik Huelsmann wrote:
>> > > On 11/16/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
>> > >> What happened to this patch?
>> > >
>> > > Nothing: it's still sitting in my working copy. But, I think I should
>> > > apply it, given Peter's reaction.
>> >
>> > I don't think this ever got applied; shall I put it in the issue
>> tracker?
>> >
>> > -Hyrum
>> >
>> > >> With regards
>> > >> Kamesh Jayachandran
>> > >> Kamesh Jayachandran wrote:
>> > >> > Erik Huelsmann wrote:
>> > >> >> On 10/9/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
>> > >> >>> I like this change.
>> > >> >>> One small suggestion, Can you attach the patch instead of inline
>> > >> text?
>> > >> >>>
>> > >> >>> Erik Huelsmann wrote:
>> > >> >>> > Our current configure script warns at the end if BDB hasn't
>> been
>> > >> >>> > found. Given that it's now just one of the components that
>> can be
>> > >> >>> used
>> > >> >>> > Index: configure.in
>> > >> >>> >
>> ===================================================================
>> > >> >>> > --- configure.in (revision 21833)
>> > >> >>> > +++ configure.in (working copy)
>> > >> >>> >
>> > >> >>> > -You don't seem to have Berkeley DB version $db_version or
>> newer
>> > >> >>> > -installed and linked to APR-UTIL. We have created
>> Makefiles which
>> > >> >>> > -will build without the Berkeley DB back-end; your
>> repositories
>> > >> will
>> > >> >>> > -use FSFS as the default back-end. You can find the latest
>> > >> >>> version of
>> > >> >>> > -Berkeley DB here:
>> > >> >>> > - http://www.sleepycat.com/download/index.shtml
>> > >> >>> > -])
>> > >> >>> > -;;
>> > >> >>> > + AC_MSG_NOTICE([ BerkeleyDB no])
>> > >> >>> > + ;;
>> > >> >>> > + "yes" )
>> > >> >>> > + AC_MSG_NOTICE([ BerkeleyDB $db_version])
>> > >> >>> > + ;;
>> > >> >>> > esac
>> > >> >>> > -
>> > >> >>> > +case "!$APXS!" in
>> > >> >>>
>> > >> >>> > + "!no!"|"!!" )
>> > >> >>> Why we have cruft of "!" here?
>> > >> >>
>> > >> >> Because I didn't know how to test for the empty string, but I
>> think
>> > >> >> that could just be "", right?
>> > >> >>
>> > >> >> bye,
>> > >> >>
>> > >> >> Erik.
>> > >> >>
>> > >> > case "$APXS" in
>> > >> > "no"|"")
>> > >> > echo "no"
>> > >> > ;;
>> > >> > * )
>> > >> > echo "default"
>> > >> > ;;
>> > >> > esac
>> > >> >
>> > >> > The above snippet works fine in my bash. If testing the empty
>> string
>> > >> > is really a problem, should we not do the same for others too like
>> > >> > "$SWIG"?
Received on Wed Feb 28 16:25:20 2007