[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]Bogus operational logging if scheduled commit has got deletion of file(with no lock in repo)

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-02-14 13:14:04 CET

Hi All,

Find the attached patch and log.

With regards
Kamesh Jayachandran

[[[
  'Commits' which has some file (without any lock) to be deleted causes bogus
   operational log like , 'unlock /path/for/which/no/lock/exists/in/repo'.

* subversion/mod_dav_svn/lock.c
  (remove_lock):
   Set SVN-ACTION only if 'svn_repos_fs_unlock' is successful.

Patch by: kameshj
Found by: Honey George <george@collab.net>
]]]

Index: subversion/mod_dav_svn/lock.c
===================================================================
--- subversion/mod_dav_svn/lock.c (revision 23390)
+++ subversion/mod_dav_svn/lock.c (working copy)
@@ -843,15 +843,15 @@
         return dav_svn__convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
                                     "Failed to remove a lock.",
                                     resource->pool);
+
+ /* Log the unlocking as a 'high-level' action. */
+ apr_table_set(resource->info->r->subprocess_env, "SVN-ACTION",
+ apr_psprintf(resource->info->r->pool,
+ "unlock '%s'",
+ svn_path_uri_encode(resource->info->repos_path,
+ resource->info->r->pool)));
     }
 
- /* Log the unlocking as a 'high-level' action. */
- apr_table_set(resource->info->r->subprocess_env, "SVN-ACTION",
- apr_psprintf(resource->info->r->pool,
- "unlock '%s'",
- svn_path_uri_encode(resource->info->repos_path,
- resource->info->r->pool)));
-
   return 0;
 }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 14 13:13:40 2007

This is an archived mail posted to the Subversion Dev mailing list.