[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Bogus operational logging if scheduled commit has got deletion of file(with no lock in repo)

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-14 13:26:22 CET

On Wed, Feb 14, 2007 at 05:44:04PM +0530, Kamesh Jayachandran wrote:
> [[[
> 'Commits' which has some file (without any lock) to be deleted causes bogus
> operational log like , 'unlock /path/for/which/no/lock/exists/in/repo'.
>
> * subversion/mod_dav_svn/lock.c
> (remove_lock):
> Set SVN-ACTION only if 'svn_repos_fs_unlock' is successful.
>

The log message could use some work. I'd find it easier to read
something more like:

[[[
mod_dav_svn: fix the incorrect logging of commits that include deletions
as 'unlock' operations.

* subversion/mod_dav_svn/lock.c
  (remove_lock): Set SVN-ACTION only when there is a lock token to
    unlock.
]]]]

The patch itself looks generally good (although I've not tested it),
though it did look like it might have caused lines to go over the
80-character limit.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Wed Feb 14 13:26:41 2007

This is an archived mail posted to the Subversion Dev mailing list.