Re: [PATCH] cleanup fails on missing .svn/tmp

Hi,

> I'm not that familiar with the code myself, but I'm surprised that we
> unconditionally remove the contents without checking them first

Well its good to do so because the tmp/ area might have some old files
being lying around that we don't want to keep (hence the name tmp/).
Instead of looking for these files, the whole tmp/ is just removed
completely and rebuild.

The two lines in the code doing this are:

----- subversion/libsvn_wc/adm_files.c:1225
  /* ... create tmp_path here [...] */

  SVN_ERR(svn_io_remove_dir(tmp_path, pool));
  /* Now, rebuild the tmp area. */
  SVN_ERR(init_adm_tmp_area(adm_access, pool));
------
Yes, remove unconditionally the whole tmp/ directory and rebuild it.

cheers,
  -henner

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 6 17:22:36 2007