[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cleanup fails on missing .svn/tmp

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-06 18:44:41 CET

On Tue, 06 Feb 2007, Malcolm Rowe wrote:

> On Tue, Feb 06, 2007 at 03:50:17PM +0100, Henner Zeller wrote:
> > >I'm not that familiar with the code myself, but I'm surprised that we
> > >unconditionally remove the contents without checking them first
> >
> > Well its good to do so because the tmp/ area might have some old files
> > being lying around that we don't want to keep (hence the name tmp/).
> > Instead of looking for these files, the whole tmp/ is just removed
> > completely and rebuild.
> >
> Okay, that does make sense. I see that we only recreate the tmp/ area
> after we run the log for the wc, which will presumably fail if there are
> files referenced in the log that don't exist in tmp/ (because tmp/
> itself doesn't exist).

I'm in favor of this patch. It passes the test suite; I'll be
committing it later today unless any other issues with it are raised.

- dan

  • application/pgp-signature attachment: stored
Received on Tue Feb 6 18:44:54 2007

This is an archived mail posted to the Subversion Dev mailing list.