Re: [PATCH] make the crash handler optional

Daniel Rall wrote:

> This patch seems conceptually fine. However, I think the crash
> handler should be compiled in by default (as it is now); this patch
> changes that behavior.

Sure. But you can just patch your build scripts and always set that define.

My problem right now is that the crash handler part doesn't compile on
x64, so my nightly build fails. Even if I exclude the crash* files from
the build, the little part in cmdline.c which (right now) is not
excluded makes the build fail when linking due to the missing functions
(which I excluded from the build).

Stefan

>> [[[
>> Make using the crash handler on windows optional.
>> * subversion/libsvn_subr/cmdline.c : add #ifdef to include the crash handler
>> ]]]
>> Index: subversion/libsvn_subr/cmdline.c
>> ===================================================================
>> --- subversion/libsvn_subr/cmdline.c (revision 23249)
>> +++ subversion/libsvn_subr/cmdline.c (working copy)
>> @@ -105,8 +105,10 @@
>> }
>> #endif /* _MSC_VER < 1400 */
>>
>> +#ifdef SVN_USE_CRASHHANDLER
>> /* Attach (but don't load) the crash handler */
>> SetUnhandledExceptionFilter(svn_unhandled_exception_filter);
>> +#endif
>>
>> #endif /* WIN32 */

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org