Re: [PATCH] make the crash handler optional

On Sat, 27 Jan 2007, Stefan Küng wrote:

> Subversion on windows now has a nice crash handler. That's good.
> But it should be optional to compile it in. The reason is simple:
> some people might not want it.
>
> Also, the crash handler can't be compiled for x64 systems and therefore
> can't be used anyway.
>
> Attached is a patch which introduces a new define SVN_USE_CRASHHANDLER.
> If it is defined, the crash handler is used, otherwise not.

This patch seems conceptually fine. However, I think the crash
handler should be compiled in by default (as it is now); this patch
changes that behavior.

> [[[
> Make using the crash handler on windows optional.
> * subversion/libsvn_subr/cmdline.c : add #ifdef to include the crash handler
> ]]]
> Index: subversion/libsvn_subr/cmdline.c
> ===================================================================
> --- subversion/libsvn_subr/cmdline.c (revision 23249)
> +++ subversion/libsvn_subr/cmdline.c (working copy)
> @@ -105,8 +105,10 @@
> }
> #endif /* _MSC_VER < 1400 */
>
> +#ifdef SVN_USE_CRASHHANDLER
> /* Attach (but don't load) the crash handler */
> SetUnhandledExceptionFilter(svn_unhandled_exception_filter);
> +#endif
>
> #endif /* WIN32 */