[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changelist API : enhancement request

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-01-16 22:53:41 CET

Hyrum K. Wright wrote:
> Malcolm Rowe wrote:
>> On Tue, Jan 16, 2007 at 08:08:30PM +0100, Stefan Küng wrote:
>>> Since assigning items to a changelist one-by-one requires a lot of disk
>>> access (opening the entries file, add the changelist entry, save the
>>> file and close it again) if it's done for many files at once, I'd like
>>> to request to change that API to take multiple paths instead of just one.
>> +1. That sounds like an incredibly sensible idea.
> Stefan,
> I've changed the API to take an array instead of a single path. Would
> you look over this patch and make sure that it does what you want it to?

I've checked the patch and it seems to work. But I haven't tested
everything yet since I'm still not finished implementing the whole
feature in TSVN yet. For now, I have a similar approach to handle
multiple paths.
I guess you will remove those printf commands later? Because they're
useless for an UI client since those don't have a console output.

I hope to have the feature implemented in TSVN by the end of the week. I
can then do more tests and report back.

> Note that we don't yet make the same interface change to
> svn_wc_set_changelist(), mainly due to the lack of notification support.
> Once notification support gets added, we can easily push the array
> interface down to libsvn_wc.

That would be good. Only with a change to svn_wc_set_changelist() does
the multiple paths make sense, otherwise we won't gain any performance.

btw: is the string length of the changeset name limited? The docs don't
mention anything about that, so I assume it's not?
And what's the encoding of that string? Since it's an char array I
assumed it should be utf8, but if that feature stays local to the
working copy, it could of course also be just the local codepage.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 16 22:53:56 2007

This is an archived mail posted to the Subversion Dev mailing list.