[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changelist API : enhancement request

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-01-16 22:14:57 CET

Malcolm Rowe wrote:
> On Tue, Jan 16, 2007 at 08:08:30PM +0100, Stefan Küng wrote:
>> Since assigning items to a changelist one-by-one requires a lot of disk
>> access (opening the entries file, add the changelist entry, save the
>> file and close it again) if it's done for many files at once, I'd like
>> to request to change that API to take multiple paths instead of just one.
>>
>
> +1. That sounds like an incredibly sensible idea.

Stefan,
I've changed the API to take an array instead of a single path. Would
you look over this patch and make sure that it does what you want it to?

Note that we don't yet make the same interface change to
svn_wc_set_changelist(), mainly due to the lack of notification support.
 Once notification support gets added, we can easily push the array
interface down to libsvn_wc.

-Hyrum

[[[
Make svn_client_set_changelist() accept an array of paths.

* subversion/include/svn_client.h
  (svn_client_set_changelist): Make the path argument an array, and
  adjust docs.

* subversion/libsvn_client/changelist.c
  (svn_client_set_changelist): Set the callback status for each target
  in the paths array.

* subversion/svn/changelist-cmd.c
  (svn_cl__changelist): Remove loop, just call the client library using
  the targets array.
]]]

Received on Tue Jan 16 22:15:12 2007

This is an archived mail posted to the Subversion Dev mailing list.