Re: Fwd: [PATCH] Make win_tests.py work out-of-the-box

On 1/8/07, Branko Èibej <brane@xbc.nu> wrote:
> Suraj Barkale wrote:
> > Branko,
> > I checked out subversion trunk and added library dependencies. The
> > build went smoothly but tests began to fail. At first culprit was BDB
> > & OpenSSL dlls were not copied to output directory which was easy to
> > fix.
>
> Yeah, I guess that's my bad -- most people have those in their path,
> since they have the Subversion binaries in their path, too.
>
> However, those DLLs should be copied to the root of the test tree, like
> the APR DLLs, not to the build output directory; I hope that's what you
> mean, I haven't time to look at the commits right this minute.

Hmm, we currently copy all dlls to the build tree, not the test tree.

> > Copying the dlls fixed C test cases but Python test cases were
> > still failing. After looking into INSTALL, I found that you need to
> > copy 'cmdline' directory to build directory because locations of
> > executables were hardcoded in 'svntest/main.py'.
>
> I have no idea who wrote that and why, as it simply isn't true. The
> python tests should always run from the source tree.

Correct.

> The Python tests do expect a certain structure to exist. I've always
> tested outside the source tree (that is, the test /data/ were outside
> the source tree), so maybe in-tree tests don't work because part of the
> structure that's created with out-of-tree tests is missing.

The only problem with in-tree tests is that we don't create the
'subversion\tests\cmdline' directory. This is trivial to fix:

Index: win-tests.py
===================================================================
--- win-tests.py (revision 22924)
+++ win-tests.py (working copy)
@@ -447,13 +447,14 @@
      os.chdir(abs_objdir)
      baton = copied_execs
      os.path.walk('subversion', copy_execs, baton)
- create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
    except:
      os.chdir(old_cwd)
      raise
    else:
      os.chdir(old_cwd)

+create_target_dir(CMDLINE_TEST_SCRIPT_NATIVE_PATH)
+
 # Ensure the tests directory is correctly cased
 abs_builddir = fix_case(abs_builddir)

-- 
Vlad