[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: [PATCH] Make win_tests.py work out-of-the-box

From: Branko Čibej <brane_at_xbc.nu>
Date: 2007-01-08 12:33:19 CET

Suraj Barkale wrote:
> Branko,
> I checked out subversion trunk and added library dependencies. The
> build went smoothly but tests began to fail. At first culprit was BDB
> & OpenSSL dlls were not copied to output directory which was easy to
> fix.

Yeah, I guess that's my bad -- most people have those in their path,
since they have the Subversion binaries in their path, too.

However, those DLLs should be copied to the root of the test tree, like
the APR DLLs, not to the build output directory; I hope that's what you
mean, I haven't time to look at the commits right this minute.

> Copying the dlls fixed C test cases but Python test cases were
> still failing. After looking into INSTALL, I found that you need to
> copy 'cmdline' directory to build directory because locations of
> executables were hardcoded in 'svntest/main.py'.

I have no idea who wrote that and why, as it simply isn't true. The
python tests should always run from the source tree.

The Python tests do expect a certain structure to exist. I've always
tested outside the source tree (that is, the test /data/ were outside
the source tree), so maybe in-tree tests don't work because part of the
structure that's created with out-of-tree tests is missing.

> This patch also adds a command line option to 'svntest/main.py' to
> specify location of build directory eliminating the need to copy
> cmdline directory.

Since copying the cmdline directory was never necessary, this option
isn't either.

> I have built subversion for the first time so I don't know if I am
> doing something wrong.

For now, I suggest you test outside the source tree, as that's
guaranteed to work.

To clarify: you have to run win-tests.py from the source tree, that is,
your current directory must be the top of the working copy; then you
tell win-tests.py where to put your test output.

> Thanks & Regards,
> Suraj
> On 1/8/07, Branko Čibej <brane@xbc.nu> wrote:
>> Suraj Barkale wrote:
>> > Can anybody please test this patch?
>>
>> Sorry but I don't understand what you're trying to fix. Exactly how does
>> win-tests.py not work out of the box? It's been working for me for ages.
>>
>> -- Brane
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 8 12:34:17 2007

This is an archived mail posted to the Subversion Dev mailing list.