[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'diff_tests.py 29 31' test failures over ra_serf

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-05 01:33:42 CET

On Tue, 05 Dec 2006, Malcolm Rowe wrote:

> On Thu, Nov 30, 2006 at 03:18:12PM -0800, Daniel Rall wrote:
> > > > Yes, I agree. I think I originally wrote those tests as well, and
> > > > ideally we'd be checking that the result consists of a set of 'hunks'
> > > > - in this case, the hunks are the complete file and property diffs from
> > > > each file - in any order.
> > >
> > > svntest.main.compare_unordered_output() may be helpful here.
> > >
> >
> > Once I fixed compare_unordered_output() to avoid clobbering its
> > parameters, it worked like charm to fix diff_tests.py over ra_serf
> > (r22525).
> >
>
> Excellent, thanks, Dan!
>
> So I assume that means that the expected output is now
> compared in a completely order-independent fashion?

Yup! Paul Burba introduced the compare_unordered_output() routine in
r21696 for a similar problem I'd reported in the past.

> I was originally thinking of doing something like that - though I didn't
> realise we already had a function to do it - but I wasn't sure that that
> might not invalidate some of the things we were trying to test. Looking
> at the tests again, I guess it looks fairly unlikely to be a problem.

Yes, I think it should be fine for this case.

- Dan

  • application/pgp-signature attachment: stored
Received on Tue Dec 5 01:28:26 2006

This is an archived mail posted to the Subversion Dev mailing list.