[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'diff_tests.py 29 31' test failures over ra_serf

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-12-05 01:03:26 CET

On Thu, Nov 30, 2006 at 03:18:12PM -0800, Daniel Rall wrote:
> > > Yes, I agree. I think I originally wrote those tests as well, and
> > > ideally we'd be checking that the result consists of a set of 'hunks'
> > > - in this case, the hunks are the complete file and property diffs from
> > > each file - in any order.
> >
> > svntest.main.compare_unordered_output() may be helpful here.
> >
>
> Once I fixed compare_unordered_output() to avoid clobbering its
> parameters, it worked like charm to fix diff_tests.py over ra_serf
> (r22525).
>

Excellent, thanks, Dan!

So I assume that means that the expected output is now
compared in a completely order-independent fashion?

I was originally thinking of doing something like that - though I didn't
realise we already had a function to do it - but I wasn't sure that that
might not invalidate some of the things we were trying to test. Looking
at the tests again, I guess it looks fairly unlikely to be a problem.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Tue Dec 5 01:04:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.