Re: [PATCH] Improve the way svnserve handles the --root option

On Mon, 04 Dec 2006, Vlad Georgescu wrote:
...
> 1. Checks that the path passed to --root exists and is a directory.

Won't this cause a problem if 'svnserve' is started before a file
system is mounted? Do we care? (Sorry I didn't think of this
earlier, Vlad.)

> 2. Makes the --root option mandatory on Windows, because the default
> that we currently use ('/') only makes sense on Unix-like OS's.

Nice! +1 to this portion of the patch for sure.

> [[[
> Improve the way svnserve handles the --root option.
>
> * subversion/svnserve/main.c:
> Include "svn_io.h".
> (main): Make the --root option mandatory on Windows. Make sure the
> path passed to --root actually exists.
> ]]]
>
> Index: subversion/svnserve/main.c
> ===================================================================
> --- subversion/svnserve/main.c (revision 22552)
> +++ subversion/svnserve/main.c (working copy)
...
> @@ -324,6 +325,7 @@
> int family = APR_INET;
> int mode_opt_count = 0;
> const char *pid_filename = NULL;
> + svn_node_kind_t kind;

Identation off here?

...
> @@ -360,7 +362,11 @@
> if (err)
> return svn_cmdline_handle_exit_error(err, pool, "svnserve: ");
>
> +#ifdef WIN32
> + params.root = NULL;

And here?

> +#else
> params.root = "/";
> +#endif /* WIN32 */
...