[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'diff_tests.py 29 31' test failures over ra_serf

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-12-01 00:18:12 CET

On Thu, 30 Nov 2006, Daniel Rall wrote:

> On Thu, 30 Nov 2006, Malcolm Rowe wrote:
>
> > On Wed, Nov 29, 2006 at 11:11:53PM -0800, Justin Erenkrantz wrote:
> > > >'diff_tests.py 29 31' are both failing for me over ra_serf because the
> > > >paths don't have their output listed in the expected order. Here's an
> > > >example from the test 29 failure, with "iota" listed before "A" (both
> > > >paths are at the root of the Greek tree):
> > >
> > > Right. This is mentioned in subversion/libsvn_ra_serf/README. The
> > > issue is that there's no guarantee in the API that the order is
> > > deterministic. I personally view this as a test suite shortcoming -
> > > not a failure in ra_serf. -- justin
> > >
> >
> > Yes, I agree. I think I originally wrote those tests as well, and
> > ideally we'd be checking that the result consists of a set of 'hunks'
> > - in this case, the hunks are the complete file and property diffs from
> > each file - in any order.
>
> svntest.main.compare_unordered_output() may be helpful here.
>
> > Unfortunately my Python-fu isn't strong enough - can anyone help?

Once I fixed compare_unordered_output() to avoid clobbering its
parameters, it worked like charm to fix diff_tests.py over ra_serf
(r22525).

- Dan

  • application/pgp-signature attachment: stored
Received on Fri Dec 1 00:13:00 2006

This is an archived mail posted to the Subversion Dev mailing list.