[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22419 - branches/multiple-moves/subversion/svn

From: David Glasser <glasser_at_mit.edu>
Date: 2006-11-24 17:12:27 CET

On 11/24/06, hwright@tigris.org <hwright@tigris.org> wrote:
> * subversion/svn/main.c
> (svn_cl__cmd_table): Add help text explaining the new functionaly of 'move'
> and 'copy'.

Typo: "functionality".

> + return svn_error_create
> + (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
> + _("Cannot mix repo and working copy paths in source list"));

Do we typically use the abbreviation "repo" in error messages?

Also, is there a reason for making this check in copy but not in move
(while your docs claim the restriction applies to both)?

> if (err)
> err = svn_cl__may_need_force(err);
> - SVN_ERR(svn_cl__cleanup_log_msg(ctx->log_msg_baton2, err));
> + SVN_ERR(svn_cl__cleanup_log_msg(ctx->log_msg_baton2, err));
>

Accidental indentation change?

Anyway, the meat of the patch looks all right to me.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 24 17:12:42 2006

This is an archived mail posted to the Subversion Dev mailing list.