[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22419 - branches/multiple-moves/subversion/svn

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2006-11-24 22:43:00 CET

David Glasser wrote:
> On 11/24/06, hwright@tigris.org <hwright@tigris.org> wrote:
>> * subversion/svn/main.c
>> (svn_cl__cmd_table): Add help text explaining the new functionaly of
>> 'move'
>> and 'copy'.
>
> Typo: "functionality".
>
>> + return svn_error_create
>> + (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
>> + _("Cannot mix repo and working copy paths in source list"));
>
> Do we typically use the abbreviation "repo" in error messages?

No. I've unabbreviated it in r22426.

> Also, is there a reason for making this check in copy but not in move
> (while your docs claim the restriction applies to both)?

No. The changes to setup_copy made in r22426 have rendered this check
unneeded. It's been removed in r22427.

>> if (err)
>> err = svn_cl__may_need_force(err);
>> - SVN_ERR(svn_cl__cleanup_log_msg(ctx->log_msg_baton2, err));
>> + SVN_ERR(svn_cl__cleanup_log_msg(ctx->log_msg_baton2, err));
>>
>
> Accidental indentation change?

Fixed in r22425.

> Anyway, the meat of the patch looks all right to me.

Thanks for the review!

-Hyrum

Received on Fri Nov 24 22:43:50 2006

This is an archived mail posted to the Subversion Dev mailing list.