[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Neon 0.26.2

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-11-24 16:51:54 CET

D.J. Heap wrote:
> On 11/24/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> D.J. Heap wrote:
> [snip]
>> > I looked at this again today and I don't see where the other uses of
>> > svn_auth_next_credentials could ever be called without
>> > svn_auth_first_credentials being called. Am I missing something in
>> > those other spots?
>>
>> I can't see either that this would segfault. But since neon obviously
>> doesn't guarantee that the 'attempt' param is zero the first time a
>> callback is called, I think it would be wise to add the additional
>> checks there too.
>>
>
>
> I'm not sure what check you mean? The auth state is a local variable
> that is always initted, so I'm not sure what could be added.

To make sure that svn_auth_first_credentials is called before
svn_auth_next_credentials is called. As we can see now, neon doesn't
promise that the 'attempt' param it passes is always zero the first time
it calls such a callback.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 24 16:52:19 2006

This is an archived mail posted to the Subversion Dev mailing list.