[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22385 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-11-22 14:46:48 CET

dlr@tigris.org wrote:
> Added: trunk/subversion/bindings/java/javahl/native/ProgressListener.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/native/ProgressListener.cpp?pathrev=22385
> ==============================================================================
> --- (empty file)
> +++ trunk/subversion/bindings/java/javahl/native/ProgressListener.cpp Tue Nov 21 14:51:40 2006
> @@ -0,0 +1,156 @@
> +void
> +ProgressListener::progress(apr_off_t nbrBytes, apr_off_t total, void *baton,
> + apr_pool_t *pool)
>

You seem to have spurious tabs here.

> +void
> +ProgressListener::onProgress(apr_off_t progress, apr_off_t total,
> + apr_pool_t *pool)
>

ditto.

> + env->DeleteLocalRef(clazz);
>
I don't know much of JNI. Why to delete local ref of 'clazz' here, which
I believe should be done only for failure conditions which is not here.
> +
> + // Call the Java method.
> + jobject jevent = env->NewObject(clazz, midCT,
> + (jlong) progress, (jlong) total);
>
Spurious tabs.
> + if (JNIUtil::isJavaExceptionThrown())
> + {
> + return;
> + }
> + env->DeleteLocalRef(clazz);
>
Why to delete local ref of clazz here?
>
>
> Modified: trunk/subversion/bindings/java/javahl/native/SVNClient.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/native/SVNClient.h?pathrev=22385&r1=22384&r2=22385
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/native/SVNClient.h (original)
>
>
Copyright year is still at 2004.
> Modified: trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp?pathrev=22385&r1=22384&r2=22385
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp (original)
> +++ trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp Tue Nov 21 14:51:40 2006
> @@ -28,6 +28,7 @@
>
>
Copyright year still 2003 here.
>
> Modified: trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java?pathrev=22385&r1=22384&r2=22385
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java (original)
> +++ trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java Tue Nov 21 14:51:40 2006
>

Copyright year still says 2005.

> Modified: trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java?pathrev=22385&r1=22384&r2=22385
> ==============================================================================
> --- trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java (original)
> +++ trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java Tue Nov 21 14:51:40 2006
> @@ -404,6 +404,20 @@
> }
>

Copyright year still says 2004.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 22 14:47:08 2006

This is an archived mail posted to the Subversion Dev mailing list.