[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r22385 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl src/org/tigris/subversion/javahl/tests

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-11-22 22:31:28 CET

On Wed, 22 Nov 2006, Kamesh Jayachandran wrote:
...
> >--- (empty file)
> >+++ trunk/subversion/bindings/java/javahl/native/ProgressListener.cpp Tue
> >Nov 21 14:51:40 2006
> >@@ -0,0 +1,156 @@
> >+void
> >+ProgressListener::progress(apr_off_t nbrBytes, apr_off_t total, void
> >*baton,
> >+ apr_pool_t *pool)
> >
>
> You seem to have spurious tabs here.
>
> >+void
> >+ProgressListener::onProgress(apr_off_t progress, apr_off_t total,
> >+ apr_pool_t *pool)
> >
>
> ditto.

Thanks, both taken care of in r22402.

> >+ env->DeleteLocalRef(clazz);
> >
> I don't know much of JNI. Why to delete local ref of 'clazz' here, which
> I believe should be done only for failure conditions which is not here.
> >+
> >+ // Call the Java method.
> >+ jobject jevent = env->NewObject(clazz, midCT,
> >+ (jlong) progress, (jlong) total);
> >
> Spurious tabs.

Done.

> >+ if (JNIUtil::isJavaExceptionThrown())
> >+ {
> >+ return;
> >+ }
> >+ env->DeleteLocalRef(clazz);
> >
> Why to delete local ref of clazz here?

That's how JNI works. When you're done with a jobject reference (as
we are at this point here), you delete your reference to it.

> >--- trunk/subversion/bindings/java/javahl/native/SVNClient.h (original)
> >
> >
> Copyright year is still at 2004.

Done.

> >---
> >trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp (original)
> >+++
> >trunk/subversion/bindings/java/javahl/native/org_tigris_subversion_javahl_SVNClient.cpp Tue Nov 21 14:51:40 2006
> >@@ -28,6 +28,7 @@
> >
> >
> Copyright year still 2003 here.

Done.

> >---
> >trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java (original)
> >+++
> >trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClient.java Tue Nov 21 14:51:40 2006
> >
>
> Copyright year still says 2005.

Done.

> >---
> >trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java (original)
> >+++
> >trunk/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/SVNClientSynchronized.java Tue Nov 21 14:51:40 2006
> >@@ -404,6 +404,20 @@
> > }
> >
>
> Copyright year still says 2004.

Done.

Thanks for the review, Kamesh!

- Dan

  • application/pgp-signature attachment: stored
Received on Wed Nov 22 22:32:55 2006

This is an archived mail posted to the Subversion Dev mailing list.