rooneg@tigris.org writes:
> Author: rooneg
> Date: Tue Sep 19 08:17:39 2006
> New Revision: 21554
> --- (empty file)
> +++ trunk/subversion/svnserve/sasl_auth.c Tue Sep 19 08:17:39 2006
> @@ -0,0 +1,358 @@
> +/*
> + * sasl_auth.c : Functions for SASL-based authentication
> + *
> + * ====================================================================
> + * Copyright (c) 2006 CollabNet. All rights reserved.
> + *
> + * This software is licensed as described in the file COPYING, which
> + * you should have received as part of this distribution. The terms
> + * are also available at http://subversion.tigris.org/license-1.html.
> + * If newer versions of this license are posted there, you may use a
> + * newer version instead, at your option.
> + *
> + * This software consists of voluntary contributions made by many
> + * individuals. For exact contribution history, see the revision
> + * history and logs, available at http://subversion.tigris.org/.
> + * ====================================================================
> + */
> +
> +#include "svn_private_config.h"
> +#ifdef SVN_HAVE_SASL
> +
> +#define APR_WANT_STRFUNC
> +#include <apr_want.h>
> +#include <apr_general.h>
> +#include <apr_strings.h>
> +
> +#include "svn_types.h"
> +#include "svn_string.h"
> +#include "svn_pools.h"
> +#include "svn_error.h"
> +#include "svn_ra_svn.h"
> +#include "svn_base64.h"
> +
> +#include "private/svn_atomic.h"
> +
> +#include "server.h"
> +
> +#include "../libsvn_ra_svn/ra_svn_sasl.h"
That looks odd, it makes svnserve a privileged user of libsvn_ra_svn
and the dependency is not obvious when looking at the ra_svn code.
Could the relevant declarations be moved to "include/svn_ra_svn.h", or
failing that could the file be moved to "private/svn_sasl.h"?
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 18:09:20 2006