[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21554 - in trunk/subversion: include libsvn_ra_svn libsvn_repos svnserve

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2006-09-19 22:37:31 CEST

On Tue, 19 Sep 2006, Garrett Rooney wrote:
...
> Ok, one catch... ra_svn_sasl.h depends on ra_svn.h for one constant
> (SVN_RA_SVN__READBUF_SIZE). Now there's no way in hell that
> SVN_RA_SVN__READBUF_SIZE should live in ra_svn_sasl.h, and similarly,
> I'm not all that thrilled about ra_svn.h living in private/, since
> it's really not used outside of libsvn_ra_svn. Any thoughts on a
> proper home for that constant?

SVN_RA_SVN__DEFAULT_SECPROPS is only used in one place:

sasl_auth.c:206: sasl_security_properties_t secprops = SVN_RA_SVN__DEFAULT_SECPROPS;

How about turning SVN_RA_SVN__DEFAULT_SECPROPS into a parameterized
macro, where the consumer supplies the buffer size, and stores the
default secprops as a static?

  • application/pgp-signature attachment: stored
Received on Tue Sep 19 22:38:46 2006

This is an archived mail posted to the Subversion Dev mailing list.