Re: svn commit: r21554 - in trunk/subversion: include libsvn_ra_svn libsvn_repos svnserve

On Tue, 19 Sep 2006, Philip Martin wrote:

> rooneg@tigris.org writes:
>
> > Author: rooneg
> > Date: Tue Sep 19 08:17:39 2006
> > New Revision: 21554
>
> > --- (empty file)
> > +++ trunk/subversion/svnserve/sasl_auth.c Tue Sep 19 08:17:39 2006
...
> > +#include "../libsvn_ra_svn/ra_svn_sasl.h"
>
> That looks odd, it makes svnserve a privileged user of libsvn_ra_svn
> and the dependency is not obvious when looking at the ra_svn code.
> Could the relevant declarations be moved to "include/svn_ra_svn.h", or
> failing that could the file be moved to "private/svn_sasl.h"?

+1 on the latter.