[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [merge-tracking] use prepared statements economically

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-08-31 11:32:02 CEST

Daniel Berlin wrote:
>> That's the way that prepare/execute works in general.
>> Whether it actually has any effect in this case, you'd need to confirm
>> by testing (and as I think that Dan is saying, it's unlikely to make
>> any really significant difference in this case, at which point you
>> probably want to start balancing code readability against marginal
>> efficiency gains).
> Yes, my only point is that it's not really going to be more efficient,
> so we shouldn't commit it if people feel it makes the code less
> readable.
> Particularly if we are going to change the mergeinfo schema anyway.
Refer my other mail to Malcom about the 'time' output with and without
this patch.
I fail to see why this makes code unreadable. Putting (prepare_statement
+ bind(s) + step + finalize) makes it more readable??
Changing the mergeinfo schema should be a different changeset that this one.

With regards
Kamesh Jayachandran

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 31 11:32:33 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.