[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [merge-tracking] use prepared statements economically

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-08-31 02:16:38 CEST

> That's the way that prepare/execute works in general.
> Whether it actually has any effect in this case, you'd need to confirm
> by testing (and as I think that Dan is saying, it's unlikely to make
> any really significant difference in this case, at which point you
> probably want to start balancing code readability against marginal
> efficiency gains).

Yes, my only point is that it's not really going to be more efficient,
so we shouldn't commit it if people feel it makes the code less
Particularly if we are going to change the mergeinfo schema anyway.
> Also, can sqlite3_reset never return an error? You're not checking
> for one.

It can.

> Regards,
> Malcolm

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 31 02:22:39 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.