RE: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

> -----Original Message-----
> From: Erik Huelsmann [mailto:ehuels@gmail.com]
> Sent: zondag 20 augustus 2006 17:53

> >
> > Why don't you just use apr_filepath_root here and everywhere else
> > where this matters?
>
>
> In that case: why introduce a function in the svn_ namespace,
> if there's a function in APR which does exactly what we want?
> But, isn't it a problem that our paths are UTF-8 while APR
> expects localized paths?
>
> Lieven: apr_filepath_root will give the root of a given
> inpath, maybe it'll work, because then it will also work for
> working copies in the root of a share or UNC path...

I'm working on it now, will have a patch tonight.

The apr_filepath_root is more then we want, because it also splits the path
in two parts, so we need to allocate new strings, pass a pool to the
function etc. But, it supports more Windows path conventions than the one I
implemented, so let's use it.

I'm gonna stick to the svn_path_is_root function because of the overhead
needed to use apr_filepath_root.

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 20 18:03:24 2006