[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2006-08-20 18:15:17 CEST

Lieven Govaerts wrote:
> > -----Original Message-----
>
>> From: Erik Huelsmann [mailto:ehuels@gmail.com]
>> Sent: zondag 20 augustus 2006 17:53
>>
>
>
>>> Why don't you just use apr_filepath_root here and everywhere else
>>> where this matters?
>>>
>> In that case: why introduce a function in the svn_ namespace,
>> if there's a function in APR which does exactly what we want?
>> But, isn't it a problem that our paths are UTF-8 while APR
>> expects localized paths?
>>
>> Lieven: apr_filepath_root will give the root of a given
>> inpath, maybe it'll work, because then it will also work for
>> working copies in the root of a share or UNC path...
>>
>
> I'm working on it now, will have a patch tonight.
>
> The apr_filepath_root is more then we want, because it also splits the path
> in two parts, so we need to allocate new strings, pass a pool to the
> function etc. But, it supports more Windows path conventions than the one I
> implemented, so let's use it.
>
> I'm gonna stick to the svn_path_is_root function because of the overhead
> needed to use apr_filepath_root.
>

I don't like the idea of rolling our own function for something that APR
already does. The overhead is trivial when compared to the extra
functionality *and portability* of apr_filepath_root. I think you need
to prove that the overhead is unacceptable performance-wise.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 20 18:17:01 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.