Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

On 8/19/06, Branko Čibej <brane@xbc.nu> wrote:
> Lieven Govaerts wrote:
> > +int
> > +svn_path_is_root(const char *path)
> > +{
> > +#if defined(WIN32)
> > + /* On Windows, X:/ is a root path! */
> > + if (path[1] == ':' && path[2] == '/' && path[3] == 0)
> > + return 1;
> > +#endif /* WIN32 */
> >
> > + return path[0] == '/' && path[1] == 0;
> > +}
> > +
> >
>
> Why don't you just use apr_filepath_root here and everywhere else where
> this matters?

In that case: why introduce a function in the svn_ namespace, if
there's a function in APR which does exactly what we want? But, isn't
it a problem that our paths are UTF-8 while APR expects localized
paths?

Lieven: apr_filepath_root will give the root of a given inpath, maybe
it'll work, because then it will also work for working copies in the
root of a share or UNC path...

Well, I was about to +1 for commit, but maybe someone has a bit of
time to test this first? Lieven, do you?

Thanks in advance!

bye,

Erik.
Received on Sun Aug 20 17:53:08 2006