Re: [PATCH] Atom 1.0 feeds for subversion
From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-20 22:07:58 CEST
Bhuvaneswaran Arumugam wrote:
Ah, I *see*. In that case we must merge the code into a unified feed
So, that's what I have done. Please review the latest version of
>>>> TODO: Implement a scheme to insert the items to the file if it already
Implementing insertion turned out to be really easy, so I just did it.
For now, item removal is NOT implemented, and needs to be. It shouldn't
>>> + self.init_output()
It seems very weird to have two functions which are only ever invoked
>>> + self.feed.setAttribute("xml:lang", "en")
Actually, it was still in your second version of the patch. I dropped it.
>>> + self.author.appendChild(self.aname)
The tags are required, yes, but they can be local variables of the
>>> + doc.createTextNode("%s" % self.format_date(datetime.datetime.now())))
Is it required to be so for feed readers to work properly? Otherwise, I
Actually, I meant, use this to replace the use of individual variables
>>> + revisions = range(start, end + 1)[-max_items:]
The point was to avoid creating a range at all - your code really just
Since this is pre-existing code in svn2rss.py, we can leave it and tidy
This is an archived mail posted to the Subversion Dev mailing list.