[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Atom 1.0 feeds for subversion

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-07-21 05:08:45 CEST

> > This script is almost inherited from svn2rss.py. So, all the
> > corrections/changes we do here must be done in that script as well.
>
> Ah, I *see*. In that case we must merge the code into a unified feed
> producing script. To do otherwise is a severe maintenance headache.
>
> So, that's what I have done. Please review the latest version of
> svn2rss.py, in which I think I have incorporated all your changes,
> though in substantially different form.

Yes, i see you have incorporated all the changes and *more* than that.
It looks to be fully complete! Thank you very much for spending your
time on this!

> >>> + doc.createTextNode("%s" % self.format_date(datetime.datetime.now())))
> >> Now? Shouldn't the time be taken from the revision's svn:date?
> >
> > I guess it should be the entry published/updated date instead of
> > revision date.
>
> Is it required to be so for feed readers to work properly? Otherwise, I
> think it might make more sense to use the revision date.

Not really. Anyhow, the revision date is already part of the feed
content. So, to avoid redundant data we can retain as it is now.

> >> desc_lines.append('')
> >> item_desc = "\n".join(desc_lines)
> >
> > Yes, i have incorporated this change.
>
> Actually, I meant, use this to replace the use of individual variables
> entirely - have a look at my version to see what I meant.

I see you no more use append() function.

> The point was to avoid creating a range at all - your code really just
> did what range() does, but manually.
>
> Since this is pre-existing code in svn2rss.py, we can leave it and tidy
> it up later.

Ok!

-- 
Regards,
Bhuvaneswaran

Received on Fri Jul 21 05:09:37 2006

This is an archived mail posted to the Subversion Dev mailing list.