[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Atom 1.0 feeds for subversion

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-07-20 21:28:33 CEST

Malcolm Rowe wrote:
> On Wed, Jul 19, 2006 at 08:55:21AM -0700, C. Michael Pilato wrote:
>>>> In my testing, the script generated a file called '.atom', not
>>>> REPOS_NAME.atom.
>>>
>>> I'm unable to repeat this issue. Can you please provide the test case ?
>> I haven't run this, but I betcha the test case is, "Run svn2atom.py from
>> inside the repository directory, and specify it as '.'" or somesuch. If the
>> code, is I suspect, nearly identical to that of svn2rss.py, then the line
>> which reads:
>>
>> % (os.path.basename(self.repos_path))
>>
>> Should actually be:
>>
>> % os.path.basename(os.path.abspath(self.repos_path)))
>>
>
> Actually, it's caused by a trailing slash on the repo path:
>
> $ ./svn2atom.py ~/svn/sample-repo/
> creates a file called '.atom', while
> $ ./svn2atom.py ~/svn/sample-repo
> creates 'sample-repo.atom'.
>
> Will the above fix work? (I'm not sure if Max has already fixed this
> in trunk's svn2rss - there was something like this that just went in).

I haven't been paying attention to this bug, I've been working solely on
getting things into a sane state to merge Atom support.

If I've fixed anything like this, it was accidental.

Max.

Received on Thu Jul 20 21:29:08 2006

This is an archived mail posted to the Subversion Dev mailing list.