Re: [PATCH] Atom 1.0 feeds for subversion

On Wed, Jul 19, 2006 at 08:55:21AM -0700, C. Michael Pilato wrote:
> >>In my testing, the script generated a file called '.atom', not
> >>REPOS_NAME.atom.
> >
> >
> > I'm unable to repeat this issue. Can you please provide the test case ?
>
> I haven't run this, but I betcha the test case is, "Run svn2atom.py from
> inside the repository directory, and specify it as '.'" or somesuch. If the
> code, is I suspect, nearly identical to that of svn2rss.py, then the line
> which reads:
>
> % (os.path.basename(self.repos_path))
>
> Should actually be:
>
> % os.path.basename(os.path.abspath(self.repos_path)))
>

Actually, it's caused by a trailing slash on the repo path:

$ ./svn2atom.py ~/svn/sample-repo/
creates a file called '.atom', while
$ ./svn2atom.py ~/svn/sample-repo
creates 'sample-repo.atom'.

Will the above fix work? (I'm not sure if Max has already fixed this
in trunk's svn2rss - there was something like this that just went in).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 20 21:02:34 2006