[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update CHANGES.

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-07-11 20:49:51 CEST

On Wed, Jul 12, 2006 at 02:17:08AM +0900, Kobayashi Noritada wrote:
> > > +* deal with perms and attributes correctly on unix and Win32 (r19924)
> >
> > I think this was a fix to a problem, so should be soemthing like 'fixed:
> > <whatever the problem was>'.
>
> I think this was correcting attributes setting on Win32 just like permission
> handling on unix, but did it fix anything...?
> Should we keep this change undocumented?
>

I tried to understand what this was doing myself. It seems like
we're deprecating svn_io_set_file_read_write_carefully() and fixing
svn_io_set_file_read_only(), svn_io_set_file_read_write(), and
svn_io_set_file_executable() to work better on Windows.

None of those seem worthy of a note in CHANGES by themselves, but I
had thought that the change was to fix a specific bug, in which case we
_should_ mention it. However, that requires that we can work out what
the bug was :-)

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 11 20:50:25 2006

This is an archived mail posted to the Subversion Dev mailing list.