[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update CHANGES.

From: D.J. Heap <djheap_at_gmail.com>
Date: 2006-07-11 21:16:24 CEST

On 7/11/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> On Wed, Jul 12, 2006 at 02:17:08AM +0900, Kobayashi Noritada wrote:
> > > > +* deal with perms and attributes correctly on unix and Win32 (r19924)
> > >
> > > I think this was a fix to a problem, so should be soemthing like 'fixed:
> > > <whatever the problem was>'.
> >
> > I think this was correcting attributes setting on Win32 just like permission
> > handling on unix, but did it fix anything...?
> > Should we keep this change undocumented?
> >
>
> I tried to understand what this was doing myself. It seems like
> we're deprecating svn_io_set_file_read_write_carefully() and fixing
> svn_io_set_file_read_only(), svn_io_set_file_read_write(), and
> svn_io_set_file_executable() to work better on Windows.
>
> None of those seem worthy of a note in CHANGES by themselves, but I
> had thought that the change was to fix a specific bug, in which case we
> _should_ mention it. However, that requires that we can work out what
> the bug was :-)
>

Yes, there was a long thread about it that crossed apr and Subversion
mailing lists.

The issue is getting Subversion to work on Win32 with apr > 0.9.x.
This was just one of several fixes to Subversion to get it working (in
this case, Subversion was treating the read-only attribute as a
permission which it is not and apr doesn't even support changing
permissions on Win32 anyway).

Subversion on Win32 with apr > 0.9.x continues to not work, however,
due to a still-existing bug in apr > 0.9.x where incomplete file
information is returned on stat calls. There has been a patch for it
for the last 9 months or so that looks like it soon may actually get
applied...maybe. With that small patch to apr, Subversion on Win32
with Apache 2.2.2 is working well and passing all tests.

So, basically, Subversion on Win32 with Apache 2.2.x will now work if
you apply the apr patch (or if it is fixed in apr someday).

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 11 21:16:59 2006

This is an archived mail posted to the Subversion Dev mailing list.