Re: [PATCH] Fix Python bindings to svn.wc.crawl_revisions2()

On Sat, 2006-06-24 at 03:54 +0530, Madan U Sreenivasan wrote:
> On Fri, 23 Jun 2006 20:27:14 +0530, Jelmer Vernooij <jelmer@samba.org>
> wrote:
>
> > On Fri, 2006-06-23 at 10:55 -0400, Garrett Rooney wrote:
> >> On 6/23/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> >> > Hi,
> >> >
> >> > [[[
> >> > Fix Python bindings to svn.wc.crawl_revisions2().
>
> + def test_craw_revisions2(self):
> Did you mean test_crawl_revisions2()?
Oops.

> + wc.crawl_revisions2(self.path, self.wc, MyReporter(self),
> + False, True, False, notify, info)
> Shouldn't the second line be indented to be below the self.path parameter?
> + self.assert_(self._finished_report)
> I think we should have _finished_report as part of the MyReporter object,
> rather than add one more member to the test suite class.
Makes sense. Fixed.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/