[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python bindings to svn.wc.crawl_revisions2()

From: David James <djames_at_collab.net>
Date: 2006-06-23 20:25:10 CEST

> > + def test_craw_revisions2(self):
> > Did you mean test_crawl_revisions2()?
> Oops.
>
> > + wc.crawl_revisions2(self.path, self.wc, MyReporter(self),
> > + False, True, False, notify, info)
> > Shouldn't the second line be indented to be below the self.path parameter?
> > + self.assert_(self._finished_report)
> > I think we should have _finished_report as part of the MyReporter object,
> > rather than add one more member to the test suite class.
> Makes sense. Fixed.

Thanks Jelmer! Overall, the patch looks great. I added a few extra
test cases and committed in 20230.

> %typemap(in) (const svn_ra_reporter2_t *reporter, void *report_baton)
> {
> $1 = &swig_py_ra_reporter2;

GCC reports a warning here unless you cast to (svn_ra_reporter2_t *).
I fixed this before committing.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 20:25:53 2006

This is an archived mail posted to the Subversion Dev mailing list.