[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python bindings to svn.wc.crawl_revisions2()

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-24 00:24:15 CEST

On Fri, 23 Jun 2006 20:27:14 +0530, Jelmer Vernooij <jelmer@samba.org>
wrote:

> On Fri, 2006-06-23 at 10:55 -0400, Garrett Rooney wrote:
>> On 6/23/06, Jelmer Vernooij <jelmer@samba.org> wrote:
>> > Hi,
>> >
>> > [[[
>> > Fix Python bindings to svn.wc.crawl_revisions2().

+ def test_craw_revisions2(self):
Did you mean test_crawl_revisions2()?

+ wc.crawl_revisions2(self.path, self.wc, MyReporter(self),
+ False, True, False, notify, info)

Shouldn't the second line be indented to be below the self.path parameter?

+ self.assert_(self._finished_report)

I think we should have _finished_report as part of the MyReporter object,
rather than add one more member to the test suite class.

Regards,
Madan U S
www.symonds.net/~madan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 18:57:09 2006

This is an archived mail posted to the Subversion Dev mailing list.