[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20180 - in trunk: . build/generator

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-06-20 19:43:29 CEST

On Tue, 20 Jun 2006, D.J. Heap wrote:

> On 6/20/06, Daniel Rall <dlr@collab.net> wrote:
> >On Mon, 19 Jun 2006, djh@tigris.org wrote:
> >...
> >> @@ -146,6 +147,11 @@
> >> # Find neon version
> >> if self.neon_path:
> >> self._find_neon()
> >> +
> >> + # Check for gen_uri_delims project in apr-util
> >> + gen_uri_path = os.path.join(self.apr_util_path,
> >"uri\\gen_uri_delims.dsp")
> >> + if (os.path.exists(gen_uri_path)):
> >> + self.have_gen_uri = 1
> >
> >Additionally, the parenthesis around the condition aren't very
> >Pythonic, nor as consistent with other similar constructs in this
> >library.
...
> Ah, yes, sorry -- feel free to correct it or I will tonight or
> tomorrow when I get a chance.

Okay --> r20190.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Tue Jun 20 19:44:22 2006

This is an archived mail posted to the Subversion Dev mailing list.