[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20180 - in trunk: . build/generator

From: D.J. Heap <djheap_at_gmail.com>
Date: 2006-06-20 19:28:10 CEST

On 6/20/06, Daniel Rall <dlr@collab.net> wrote:
> On Mon, 19 Jun 2006, djh@tigris.org wrote:
> ...
> > @@ -146,6 +147,11 @@
> > # Find neon version
> > if self.neon_path:
> > self._find_neon()
> > +
> > + # Check for gen_uri_delims project in apr-util
> > + gen_uri_path = os.path.join(self.apr_util_path, "uri\\gen_uri_delims.dsp")
> > + if (os.path.exists(gen_uri_path)):
> > + self.have_gen_uri = 1
>
> Additionally, the parenthesis around the condition aren't very
> Pythonic, nor as consistent with other similar constructs in this
> library.
> --
>
> Daniel Rall

Ah, yes, sorry -- feel free to correct it or I will tonight or
tomorrow when I get a chance.

Thanks!

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 20 19:29:55 2006

This is an archived mail posted to the Subversion Dev mailing list.