[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve test cases for svn.wc python bindings

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-17 14:08:01 CEST

On Sat, 17 Jun 2006 15:25:35 +0530, Jelmer Vernooij <jelmer@samba.org>
wrote:

> Hi Madan,
>
> On Sat, 2006-06-17 at 14:54 +0530, Madan U Sreenivasan wrote:
>> Pl. find attached some improved tests for svn.wc python bindings.
>>
>> This patch is dependant on the import of shutil module which is also
>> present in a patch I submitted earlier (but not committed, yet)...
>> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=116821
> I'll try to have a look at it later today (if nobody has committed it
> yet by then)
>
>> Pl. note that there are two failing test cases, which are supposed to
>> work as per the svn_wc.h documentation. so, I have kept them as-is
>> (added
>> comments tho). Am trying to figure out the best way to fix these
>> issues/documentation and then would come back and fix these failures.
>>
>> [[[
>> Improve existing tests for the svn.wc python binding.
>>
>> * subversion/bindings/swig/python/tests/wc.py
>> (global): import shutil.
>> (test_check_wc): Add invalid-file case.
>> (test_get_ancestry): Add invalid-file case.
>> (test_status): Add cases with varying input.
>> (test_is_normal_prop): Use failUnless instead of assert_.
>> (test_is_wc_prop): Use failUnless instead of assert_.
>> (test_is_entry_prop): Use failUnless instead of assert_.
>> (test_get_pristine_copy_path): Add test for removal of text-base
>> case.
>> ]]]
> Looks good! Two small comments from a quick glance over your patch:
> Why the assert_ -> failUnless change?

IIUC, assert_ will cause and assertion and hence an error. failUnless will
cause a failure (test failure)

> I'm not sure whether adding tests that fail are a good idea - it makes
> it harder to catch real regressions. Can you comment out the failing
> ones and a TODO or send a fix along that fixes the actual bug?

Good idea. Will do that, and send the patch again. Thanks. :)

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 17 13:37:46 2006

This is an archived mail posted to the Subversion Dev mailing list.