Re: [PATCH] Improve test cases for svn.wc python bindings

Hi Madan,

On Sat, 2006-06-17 at 14:54 +0530, Madan U Sreenivasan wrote:
> Pl. find attached some improved tests for svn.wc python bindings.
>
> This patch is dependant on the import of shutil module which is also
> present in a patch I submitted earlier (but not committed, yet)...
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=116821
I'll try to have a look at it later today (if nobody has committed it
yet by then)

> Pl. note that there are two failing test cases, which are supposed to
> work as per the svn_wc.h documentation. so, I have kept them as-is (added
> comments tho). Am trying to figure out the best way to fix these
> issues/documentation and then would come back and fix these failures.
>
> [[[
> Improve existing tests for the svn.wc python binding.
>
> * subversion/bindings/swig/python/tests/wc.py
> (global): import shutil.
> (test_check_wc): Add invalid-file case.
> (test_get_ancestry): Add invalid-file case.
> (test_status): Add cases with varying input.
> (test_is_normal_prop): Use failUnless instead of assert_.
> (test_is_wc_prop): Use failUnless instead of assert_.
> (test_is_entry_prop): Use failUnless instead of assert_.
> (test_get_pristine_copy_path): Add test for removal of text-base case.
> ]]]
Looks good! Two small comments from a quick glance over your patch:
Why the assert_ -> failUnless change?

I'm not sure whether adding tests that fail are a good idea - it makes
it harder to catch real regressions. Can you comment out the failing
ones and a TODO or send a fix along that fixes the actual bug?

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/