On 6/17/06, Osku Salerma <osku@iki.fi> wrote:
> On Sat, 17 Jun 2006, Ivan Zhakov wrote:
>
> > On 6/17/06, Osku Salerma <osku@iki.fi> wrote:
> > > It is called from libsvn_client as well (add.c, commit.c), so it can't be
> > > private to libsvn_wc, unless I'm misunderstanding what private means in
> > > this context.
> > >
> > Sorry, I missed reference from libsvn_client.
> > So in this case it should be public function svn_wc_match_ignore_list.
> > But anyway I consider it should be libsvn_wc function.
>
> The attached new patch moves it to libsvn_wc/util.c and adds a pool
> parameter since future users in all probability will need it.
>
> [[[
> Make all svn:ignore pattern matching go through a single function to make
> future enhancements easier.
>
> * subversion/include/svn_wc.h
> (svn_wc_match_ignore_list): New function declaration.
>
> * subversion/libsvn_wc/util.c
> (svn_wc_match_ignore_list): New function.
>
> * subversion/libsvn_wc/status.c (send_unversioned_item)
> subversion/libsvn_client/add.c (add_dir_recursive)
> subversion/libsvn_client/commit.c (import_dir, import):
>
> Use svn_wc_match_ignore_list instead of svn_cstring_match_blob_list.
> ]]]
>
Commited in r20155. Thanks!
--
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 17 12:57:42 2006