[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings.

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2006-06-13 15:33:05 CEST

Hi,

> > > > Here is a patch to add a new method, Svn::Core::LogChangedPath#copied?
> > > > implemented with Svn::Util.copy?.
> > >
> > > +1
> > > I'm very happy if you add a test case for your patch.
> > > Anyway, please commit, nori.
> >
> > Here attached a new patch with a test case.
>
> I found some codings I don't like in your test case. What
> about the following my idea?

Great!!
Thank you very much for simplifying my code.
Actually I thought that stuff was ugly and I wanted to do exactly what you've
done, but I had no idea to do it immediately...

Shall I commit this one with my original patch for
Svn::Core::LogChangedPath#copied? ?

-nori

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 13 15:33:43 2006

This is an archived mail posted to the Subversion Dev mailing list.